Changeset 357

Show
Ignore:
Timestamp:
04/10/06 04:12:42 (3 years ago)
Author:
snowblink
Message:

Added simple email validation to the User model.
This should also take care of the unit test failures detailed in Ticket #114

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved
  • login_engine/branches/rb_1.0/lib/login_engine/authenticated_user.rb

    r340 r357  
    1818        validates_uniqueness_of :login 
    1919        validates_uniqueness_of :email 
     20        validates_format_of :email, :with => /^[^@]+@.+$/ 
    2021 
    2122        validates_presence_of :password, :if => :validate_password? 
  • login_engine/branches/rb_1.0/test/unit/user_test.rb

    r282 r357  
    3333    u = User.new     
    3434    u.login = "nonbob" 
     35    u.email = "bobs@email.com" 
    3536 
    3637    u.change_password("tiny") 
     
    5657    u = User.new   
    5758    u.change_password("bobs_secure_password") 
     59    u.email = "bobs@email.com" 
    5860 
    5961    u.login = "x" 
     
    8890    u.login = "nonexistingbob" 
    8991    u.change_password("bobs_secure_password") 
     92    u.email = "bobs@email.com" 
    9093       
    9194    assert u.save   
    9295     
    9396  end 
    94    
     97 
     98  def test_email_should_be_nominally_valid 
     99    u = User.new 
     100    u.login = "email_test" 
     101    u.change_password("email_test_password") 
     102 
     103    assert !u.save 
     104    assert u.errors.invalid?('email') 
     105 
     106    u.email = "invalid_email" 
     107    assert !u.save 
     108    assert u.errors.invalid?('email') 
     109 
     110    u.email = "valid@email.com" 
     111    assert u.save 
     112  end 
     113 
    95114end